Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Termux Hosting To Docs #490

Merged
merged 21 commits into from
May 12, 2024
Merged

Conversation

KristalliDev
Copy link
Contributor

Added docs for Termux hosting

Description

Adding Termux Hosting To Documentation For Alternative Self-Hosting, this is from a thread in the Discord server with the same header.

Type of change

  • This change requires a documentation update

How Has This Been Tested?

This has been tested on a samsung SM-A6060 on the latest version of Termux from F-Droid.

Test Configuration:

  • Firmware version: -
  • Hardware: samsung SM-A6060
  • Toolchain: apt-get
  • SDK: DotNET 8.0

Checklist:

  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@Aiko-IT-Systems/discatsharp

Added docs for Termux hosting

Signed-off-by: Kristalli <119222895+KristalliDev@users.noreply.github.com>
@KristalliDev KristalliDev requested review from NyuwBot, Lulalaby and a team as code owners May 11, 2024 08:07
@NyuwBot NyuwBot added the documentation Improvements or additions to documentation label May 11, 2024
Copy link
Member

@TheXorog TheXorog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, more options and documentation is always good.

DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
@TheXorog TheXorog removed the request for review from Saalvage May 11, 2024 08:38
I hope this is enough, thank you xorg for the help

Signed-off-by: Kristalli <119222895+KristalliDev@users.noreply.github.com>
@KristalliDev
Copy link
Contributor Author

With this I hope, this is finally over. Thanks @TheXorog for feedback and figuring stuff out.

Signed-off-by: Kristalli <119222895+KristalliDev@users.noreply.github.com>
@KristalliDev KristalliDev marked this pull request as draft May 11, 2024 11:34
works fine now

Signed-off-by: Kristalli <119222895+KristalliDev@users.noreply.github.com>
Pain.

Signed-off-by: Kristalli <119222895+KristalliDev@users.noreply.github.com>
@KristalliDev KristalliDev marked this pull request as ready for review May 11, 2024 13:22
DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
Copy link
Member

@TheXorog TheXorog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting there. I spotted a few grammar mistakes and suggested some adjustments to some points.

DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
DisCatSharp.Docs/articles/misc/hosting.md Outdated Show resolved Hide resolved
@KristalliDev
Copy link
Contributor Author

We're getting there. I spotted a few grammar mistakes and suggested some adjustments to some points.

Yeah, my grammar is pretty bad and my brain was fried, hah.

@TheXorog
Copy link
Member

We're getting there. I spotted a few grammar mistakes and suggested some adjustments to some points.

Yeah, my grammar is pretty bad and my brain was fried, hah.

No worries, that's what we're here for. 🤝

KristalliDev and others added 8 commits May 12, 2024 06:43
Co-authored-by: Mira <xorog@outlook.de>
Signed-off-by: Kristalli <119222895+KristalliDev@users.noreply.github.com>
Co-authored-by: Mira <xorog@outlook.de>
Signed-off-by: Kristalli <119222895+KristalliDev@users.noreply.github.com>
Co-authored-by: Mira <xorog@outlook.de>
Signed-off-by: Kristalli <119222895+KristalliDev@users.noreply.github.com>
Co-authored-by: Mira <xorog@outlook.de>
Signed-off-by: Kristalli <119222895+KristalliDev@users.noreply.github.com>
Co-authored-by: Mira <xorog@outlook.de>
Signed-off-by: Kristalli <119222895+KristalliDev@users.noreply.github.com>
Co-authored-by: Mira <xorog@outlook.de>
Signed-off-by: Kristalli <119222895+KristalliDev@users.noreply.github.com>
Co-authored-by: Mira <xorog@outlook.de>
Signed-off-by: Kristalli <119222895+KristalliDev@users.noreply.github.com>
Co-authored-by: Mira <xorog@outlook.de>
Signed-off-by: Kristalli <119222895+KristalliDev@users.noreply.github.com>
KristalliDev and others added 3 commits May 12, 2024 06:46
Co-authored-by: Mira <xorog@outlook.de>
Signed-off-by: Kristalli <119222895+KristalliDev@users.noreply.github.com>
Co-authored-by: Mira <xorog@outlook.de>
Signed-off-by: Kristalli <119222895+KristalliDev@users.noreply.github.com>
Signed-off-by: Kristalli <119222895+KristalliDev@users.noreply.github.com>
@TheXorog TheXorog self-requested a review May 12, 2024 01:09
Signed-off-by: Kristalli <119222895+KristalliDev@users.noreply.github.com>
Signed-off-by: Mira <xorog@outlook.de>
@TheXorog TheXorog self-requested a review May 12, 2024 01:12
TheXorog
TheXorog previously approved these changes May 12, 2024
Copy link
Member

@TheXorog TheXorog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we just wait for Lala to fix the heading. I didn't find anything that looks out of place. Thanks for your contribution! 👍

Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
@Lulalaby
Copy link
Member

Since it counts as self hosting, i believe putting it under the self-host category, is the best choice

Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
@Lulalaby Lulalaby requested a review from TheXorog May 12, 2024 01:38
@Lulalaby
Copy link
Member

@TheXorog please check once again

@Lulalaby Lulalaby enabled auto-merge May 12, 2024 01:38
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:3

@Lulalaby
Copy link
Member

Also mira, if its merged: https://github.com/Aiko-IT-Systems/DisCatSharp/actions/workflows/documentation.yml please execute <3

@TheXorog
Copy link
Member

Should be fine

@Lulalaby Lulalaby merged commit f25067a into Aiko-IT-Systems:main May 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

None yet

4 participants