chore: bump integration test container startup timeout #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@C0urante check the |
C0urante
force-pushed
the
bump-container-startup-timeout
branch
from
61abbc5
to
f18fe5b
Compare
|
Sorry about that @eliax1996! Should be good to go now. |
|
No need to say sorry 😄 I'll that all the times |
eliax1996
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests can be pretty flaky on my machine, and increasing the startup timeout for their containers gives me a consistent green run. In case others are running into this, we should 1) centralize the definition of our container startup timeouts (done via the
AbsxtractIT.CONTAINER_STARTUP_TIMEOUTfield) and 2) use a higher timeout (five minutes works well on my machine but I'm open to suggestions).