ujson instead of json #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not too keen on the idea, the JSON files that pglookout touches are minimal i.e. I doubt you'll be able to measure any performance impact from this. This in comparison to adding a new dependency that needs to be kept up to date. Also your commit doesn't have any rationale for why you want to actually do this. |
|
Agreed the advantage is on lower side and dependency addition further lowers the overall benefit. If the other PR (draining the queue) is not the correct way ahead then when the queue has filled with pending items, this will help speed up the consumer thread |
|
#65 got merged, so this is not needed. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.