object_storage: config models improvements #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rominf
force-pushed
the
rominf-object-storage-configs
branch
from
64ac6fd
to
b562e7a
Compare
rominf
force-pushed
the
rominf-object-storage-configs
branch
3 times, most recently
from
fa0c76e
to
c4f84ef
Compare
added 6 commits
August 24, 2023 13:54
Note that this class is not the same as Python 3.11 `StrEnum`, it is much more basic, but it suits our needs.
This will allow to use object storage configs in nested pydantic models downstream in Discriminated Unions, see: https://docs.pydantic.dev/1.10/usage/types/#discriminated-unions-aka-tagged-unions
The aim is to prevent credential leaks.
This field is present in transfer class (it is optional) - everything will work.
For some object storage operations bucket name is not required (for listing bucket for example).
rominf
force-pushed
the
rominf-object-storage-configs
branch
from
c4f84ef
to
0e8c61e
Compare
fingon
approved these changes
Aug 24, 2023
|
|
||
|
|
||
| class LocalObjectStorageConfig(StorageModel): | ||
| directory: str | ||
| directory: DirectoryPath |
There was a problem hiding this comment.
In theory this may break something, as object is no longer string, but I hope not (and local target should be really primarily used for testing in any case).
There was a problem hiding this comment.
It did break things :(
It became impossible to create that model without the validation failing because the folder does not exist at the time the configuration is created. That breaks tests and will break use cases where the configuration is prepared and (de)serialized in a different environment (chroot, container, server, etc...) or just before that directory is created.
I'll prepare a revert PR.
[edit] #140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
StorageDriverenumWhy this way
To allow downstream use rohmu configs instead of code duplication. See commit messages for more info.