Add saveMinecraft into the server status #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This massively speeds up sync times for me, since Loom no longer has to remap 45+ Fabric API modules. Additionally, this allows users to install No Chat Reports without Fabric API, as the required modules are already included.
Added Finnish translation. // Lisätty suomenkielinen käännös.
…ation Spanish translation
Aizistral
requested changes
Aug 17, 2022
| private void onSerialize(ServerStatus serverStatus, Type type, JsonSerializationContext context, | ||
| CallbackInfoReturnable<JsonElement> info) { | ||
| if (!NoReportsConfig.includeQueryData()) return; | ||
| ((JsonObject)info.getReturnValue()).addProperty("noChatReporting", NoReportsConfig.convertToGameMessage()); |
There was a problem hiding this comment.
Why have you decided to tie noChatReporting value to message conversion? NCR removes signatures both ways, conversion is just an optional alternative strategy for doing that.
Aizistral
requested changes
Aug 17, 2022
…dMenu-Cloth Adds ModMenu support for 1.19.2
plus added a newline to option.NoChatReports.whitelistedServers.tooltip
|
Closed in favor of more clean and up-to-date implementation in #169. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You should display a small icon next to servers that support this. So show that no chat report is used on the server, should be easy to add the icon with what ive done