You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a color selector control. This control allows users to use the color input type to select a color as a string (hex format). This grants users the ability to quickly choose/change colors on the fly without needing to have pre selected them. Personally I was looking for a way to quickly test out new colors and previously I was using a separate website's color selector to pick a color and then copy pasting the hex code into a string control. This makes that process a lot more streamlined and reactive. #573#30
Additional context
I am new to VUE and was struggling with the best way to update the state, when I was just using the emit function that I saw in other controls, it was super slow, probably because it was doing it so much. I ended up implemented a throttle function so it will only shoot every 15ms which fixed it. If there is a better way then let me know. I tried to follow the guidelines as best as possible, let me know if anything needs to be changed :)
What is the purpose of this pull request?
Bug fix
New Feature
Documentation update
Other
Before submitting the PR, please make sure you do the following
If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
I've never used cypress before so I could be wrong but it seems that since the color selector control also uses a text input it is returning two when looking for the HstText, I will fix this shortly and add a test case for the color selector control as well.
I had to change the way that cypress gets the text control since the color selector control also uses a text input. Instead of grabbing the ones that contain input[type="text"] (which isn't recommended under cypress best practices), it grabs it by .contains("HstText"). I did the same with the new color select test. This fixed the HstText test.
I also updated the amount of stories in it to 30 from 29 since I didn't account for the new Color Select Control :)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MichaelThomas0721
changed the title
Description
This PR adds a color selector control. This control allows users to use the color input type to select a color as a string (hex format). This grants users the ability to quickly choose/change colors on the fly without needing to have pre selected them. Personally I was looking for a way to quickly test out new colors and previously I was using a separate website's color selector to pick a color and then copy pasting the hex code into a string control. This makes that process a lot more streamlined and reactive.
#573 #30
Additional context
I am new to VUE and was struggling with the best way to update the state, when I was just using the emit function that I saw in other controls, it was super slow, probably because it was doing it so much. I ended up implemented a throttle function so it will only shoot every 15ms which fixed it. If there is a better way then let me know. I tried to follow the guidelines as best as possible, let me know if anything needs to be changed :)
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).