Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostic warning about any global #1

Merged
merged 17 commits into from
Mar 22, 2023
Merged

Conversation

AndreaWalchshoferSCCH
Copy link
Collaborator

@AndreaWalchshoferSCCH AndreaWalchshoferSCCH commented Feb 13, 2023

  • diagnostic 'global-element' in group 'conventions', disabled by default
  • uses setting 'diagnostics.globals' for exemption list
  • isolated unit tests for diagnostic

Requires AlWoSp/vscode-lua-by-sumneko#1 for usage

@AndreaWalchshoferSCCH AndreaWalchshoferSCCH marked this pull request as ready for review February 14, 2023 11:20
@AlWoSp
Copy link
Owner

AlWoSp commented Mar 21, 2023

We should add documentation at least in English -> in doc/en-us/config.md.

locale/en-us/setting.lua Outdated Show resolved Hide resolved
script/core/diagnostics/global-element.lua Outdated Show resolved Hide resolved
script/proto/diagnostic.lua Outdated Show resolved Hide resolved
@AlWoSp AlWoSp merged commit 759e2f8 into master Mar 22, 2023
@AlWoSp AlWoSp deleted the awa/warning-for-any-global branch March 22, 2023 08:01
AlWoSp pushed a commit that referenced this pull request May 25, 2023
meta: add some spaces to improve readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants