Return empty results in group by when input is empty #1279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #927
We currently have a fallback check on empty
query.groups
so that we can populate aggregate function default value in a non-groupby SELECT. i.e.SELECT COUNT(1) as c FROM ? WHERE 1 = 2
should return[{c:0}]
.However,
query.groups
can also be empty if there is no input data to group by. In this case, we would expect AlaSQL (and other SQL engines indeed) to not return anything instead of emitting an undefined group. Add an additional check to verify thatallgroups
are empty, that is, there were no GROUP BY clause.