Skip to content
This repository has been archived by the owner on Dec 30, 2020. It is now read-only.

WIP: Add playlist tab to beatmap table, implements #40 #65

Merged
merged 3 commits into from
Sep 2, 2020

Conversation

SpellcheckerExtraordinaire
Copy link
Contributor

This adds a new tab in the local beatmap data table that displays the thumbnails of all playlists the respective beatmap is a part of, as was suggested in #40.

As I am totally unfamiliar with vue itself I might not adhere to common best practices, if anything stands out let me know.
One thing I was not able to do is overlapping the thumbnails, like your difficulty chips do. I would suppose with some familiarity this should be a two minute fix, so I'd appreciate a pointer in the right direction.

I'm on your discord with the username AngryEndUser, so you can message me over there if you like.

@SpellcheckerExtraordinaire
Copy link
Contributor Author

The code smell is interesting, as the PlaylistLocal import is definitely being used, but only as a type annotation. I assume sonarcloud only checks the compiled javascript? Then the import would indeed lose its purpose, but in that case I wonder why the tsc doesn't just get rid of it during compilation. Anyhow, I personally like annotations for readability, I can get rid of it if you want though.

Copy link
Owner

@Alaanor Alaanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the PR. Just a few change and it's all good for me 👍

The code review should answer some of your questions. As for sonarcloud you're right, false positive, you can ignore it.

src/components/beatmap/PlaylistThumbnails.vue Outdated Show resolved Hide resolved
src/components/beatmap/PlaylistThumbnails.vue Outdated Show resolved Hide resolved
src/components/beatmap/PlaylistThumbnails.vue Outdated Show resolved Hide resolved
src/libraries/beatmap/BeatmapLibrary.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Alaanor Alaanor merged commit 5a70d35 into Alaanor:master Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants