-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change MinimumOSVersion to 8.0 to support Carthage builds #352
Comments
A fresh checkout and build in Xcode produces this warning |
I am seeing the same behavior. It seems to me that the best course of action would be to have the deployment target set to 8.0 in the project. That will solve the problem for Carthage and won't affect CocoaPods. For users that are deploying their app with a deployment target of 7.0, they cannot submit to Apple using Frameworks anyways. They will need to pull in the Alamofire.swift file manually into their project. This approach doesn't care what the deployment target is set to in the Maybe there's another issue at hand that I'm not aware of at the moment (please comment if so), but it seems to me that the iOS deployment target in the project should be set to 8.0 to solve all the use cases for deployment. |
+1 |
1 similar comment
👍 |
While you may get a warning. You do indeed get a submission error:
|
@mattt Any opinion on this issue? I could make a PR bumping the minimum OS version requirements if you want. |
Oh wait, there's already a PR open: #375 |
At the moment Carthage can build Alamofire for iOS but since it targets iOS 7, the resulting application cannot be submitted to iTunes Connect.
I already opened a bug report on Carthage to ask for the best course of action (Carthage/Carthage#351), they suggested to open a bug report here.
I see that some bug reports have already been closed in the past because Alamofire needs to support iOS 7 (Is the Xcode project configured that way in order to have Travis build and test against that version of iOS?).
At this point I'm not sure how to proceed.
The text was updated successfully, but these errors were encountered: