Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump podspec to 1.1.3 #287

Closed
wants to merge 2 commits into from
Closed

bump podspec to 1.1.3 #287

wants to merge 2 commits into from

Conversation

rynecheow
Copy link
Contributor

Bump podspec Alamofire version to latest release

Signed-off-by: Ryne Cheow <rynecheow@gmail.com>
s.license = 'MIT'
s.summary = 'Elegant HTTP Networking in Swift'
s.homepage = 'https://github.com/Alamofire/Alamofire'
s.social_media_url = 'http://twitter.com/mattt'
s.authors = { 'Mattt Thompson' => 'm@mattt.me' }
s.source = { :git => 'https://github.com/Alamofire/Alamofire.git', :tag => '1.1.0' }
s.source = { :git => 'https://github.com/Alamofire/Alamofire.git', :tag => '1.1.3' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make this :tag => s.version so it doesn't need to be updated in two places each time.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s.ios.deployment_target = '7.0'

is also needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimum deployment target for iOS using Swift in CocoaPods is iOS 8.0, so it should stay as is.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylef could you let me know a link (of a web page or a blog) on specifying the requirement (iOS 8)?
FYI, Alamofire itself requires iOS 7 or later.

Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS only supports frameworks on iOS 8 and onwards, you cannot use Swift with static libraries. Therefore it's only possible to use Alamofire with iOS 8 and onwards with CocoaPods.

If you was to lint the pod spec with iOS 7, the linker itself will mention this:

$ pod lib lint

 -> URITemplate (1.0.1)
    - NOTE  |  ld: warning: embedded dylibs/frameworks only run on iOS 8 or later

This will fail lint on the final release of CocoaPods 0.36 (CocoaPods/CocoaPods#2963).

Signed-off-by: Ryne Cheow <rynecheow@gmail.com>
@mattt
Copy link
Sponsor Contributor

mattt commented Jan 13, 2015

Equivalent changes have since been applied. Thanks for the PR, @rynecheow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants