Update certificatesInBundle - addl. extensions, case sensitivity #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certificatesInBundle, check for well-formed certificates with extensiions .cer, .crt, .der, and check for upper and lower case extensions (OSX filesystem may or may not be case sensitive. iOS always is) DER is a binary encoding format PEM is an ASCII encoding format .crt is the most common certificate extension, may be DER or PEM .cer is a Microsoft extension convention, may be DER or PEM .der is a (poor) extension referring to encoding instead of contents, these may contain a certificate and/or a key.
|
Thanks for putting this together @jacobjennings...much appreciated! I made a few small formatting changes to your PR and pushed it up in 234568d still giving you attribution. Thanks again! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certificatesInBundle, check for well-formed certificates with
extensiions .cer, .crt, .der, and check for upper and lower case
extensions (OSX filesystem may or may not be case sensitive. iOS
always is)
DER is a binary encoding format
PEM is an ASCII encoding format
.crt is the most common certificate extension, may be DER or PEM
.cer is a Microsoft extension convention, may be DER or PEM
.der is a (poor) extension referring to encoding instead of
contents, these may contain a certificate and/or a key.
Apple's SecCertificateCreateWithData only accepts DER-encoded certificates