Feature - Request Image Content Types #33
Conversation
|
cc @kcharwood and @jshier |
|
|
||
| - parameter contentTypes: The additional content types. | ||
| */ | ||
| public class func addAcceptableImageContentTypes(contentTypes: Set<String>) { |
There was a problem hiding this comment.
Do we need to have a remove?
There was a problem hiding this comment.
Only scenario I think of for having a remove is a user who wants an invalid content type error for some reason. I can't think of a valid use, though more and more I'm coming to realize I have yet to experience the full range of terrible backend APIs. 👀
There was a problem hiding this comment.
Good question @kcharwood. I think @jshier hit the only use case I can think of for requiring a removal, and I don't think it's a very realistic case. I could certainly add the API for completeness, but I think I'd prefer to leave it out now, and add it when we have a use case actually come up where it makes sense to add it.
Thoughts?
There was a problem hiding this comment.
Makes sense to me, just wanted to pose the question.
…ypes Feature - Request Image Content Types
This PR adds the ability for a user to add additional acceptable image content types for validation. These changes address the challenges faced in both #28 and #29.