added condition in the UIImageViewTests test to check if af_activeRequestReceipt is nil #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jorjuela33...thanks for the pull request! Could you explain why you decided to push up this change? Does it need to be applied to other tests? |
|
@cnoon I thought that line of code was missed since the name of the test is "testThatActiveRequestIsNilAfterImageDownloadCompletes" and there is no check for that property. Regards. |
|
Haha...duh, my bad. That totally makes sense. I didn't look closely enough at the diff. Thanks! 🍻 |
cnoon
added a commit
that referenced
this pull request
Jan 3, 2016
added condition in the UIImageViewTests test to check if af_activeRequestReceipt is nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.