Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional corner cases to tests #187

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Add additional corner cases to tests #187

merged 4 commits into from
Jan 22, 2024

Conversation

dthaler
Copy link
Collaborator

@dthaler dthaler commented Jan 20, 2024

For example, some j*reg.data tests checked comparison of a register with itself and others didn't, so this makes them more consistent.

Also updates various other tests to add the case where the src and dst register are the same.

Some jump tests did it, others didn't.

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
@dthaler dthaler marked this pull request as draft January 20, 2024 01:06
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
@coveralls
Copy link

Coverage Status

coverage: 95.802% (-0.2%) from 95.978%
when pulling 2eb430f on corner-cases
into a309ef6 on main.

@dthaler dthaler marked this pull request as ready for review January 20, 2024 18:45
@Alan-Jowett Alan-Jowett merged commit a2799c0 into main Jan 22, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants