Ensures TagsHelper#tag_cloud can handle tags with no taggings.

AlanMcCann · Oct 5, 2011 · 12a59ae · 12a59ae
1 parent dcc0c62
commit 12a59ae
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/lib/acts_as_taggable_on/tags_helper.rb b/lib/acts_as_taggable_on/tags_helper.rb
@@ -9,8 +9,8 @@ def tag_cloud(tags, classes)
       max_count = tags.sort_by(&:count).last.count.to_f
 
       tags.each do |tag|
-        index = ((tag.count / max_count) * (classes.size - 1)).round
-        yield tag, classes[index]
+        index = ((tag.count / max_count) * (classes.size - 1))
+        yield tag, classes[index.nan? ? 0 : index.round]
       end
     end
   end

diff --git a/spec/acts_as_taggable_on/tags_helper_spec.rb b/spec/acts_as_taggable_on/tags_helper_spec.rb
@@ -25,4 +25,20 @@
     tags["c++"].should == "sucky"
     tags["php"].should == "sucky"
   end
+
+  it "should handle tags with zero counts (build for empty)" do
+    bob = ActsAsTaggableOn::Tag.create(:name => "php")
+    tom = ActsAsTaggableOn::Tag.create(:name => "java")
+    eve = ActsAsTaggableOn::Tag.create(:name => "c++")
+
+    tags = { }
+
+    @helper.tag_cloud(ActsAsTaggableOn::Tag.all, ["sucky", "awesome"]) do |tag, css_class|
+      tags[tag.name] = css_class
+    end
+
+    tags["java"].should == "sucky"
+    tags["c++"].should == "sucky"
+    tags["php"].should == "sucky"
+  end
 end