Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new token spec for size scale #86

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Conversation

blackfalcon
Copy link
Member

@blackfalcon blackfalcon commented Sep 23, 2022

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #71

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

This feature release will add a new scale for size tokens using a X00 value scale. This update also
deprecates the current scale of XL named values.

Screen Shot 2022-09-23 at 10 42 46 AM

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@blackfalcon blackfalcon self-assigned this Sep 23, 2022
@blackfalcon blackfalcon linked an issue Sep 23, 2022 that may be closed by this pull request
1 task
jordanjones243
jordanjones243 previously approved these changes Sep 23, 2022
@leeejune
Copy link
Contributor

@blackfalcon are we adding all of those tokens or just changing the naming convention? Previously we did not have sizes 900 (4.5rem), 700 (3.5rem), 500 (2.5rem).

This feature release will add a new scale for size
tokens using a X00 value scale. This update also
deprecates the current scale of XL named values.

Changes to be committed:
modified:   src/size/scale.json
@blackfalcon
Copy link
Member Author

Updated to include proper deprecations documentation.

Screen Shot 2022-09-26 at 1 47 48 PM

@blackfalcon
Copy link
Member Author

@blackfalcon are we adding all of those tokens or just changing the naming convention? Previously we did not have sizes 900 (4.5rem), 700 (3.5rem), 500 (2.5rem).

Both. Using the opportunity to fix the size ladder and add the new values in the same PR.

@leeejune
Copy link
Contributor

@blackfalcon Do we want to add all of those options? I added sizes 600 and 1000 because there was a need for it, but I'm not sure if we have reasons to add all of the other in between sizes (sizes 500, 700, 900).

@blackfalcon
Copy link
Member Author

@blackfalcon Do we want to add all of those options? I added sizes 600 and 1000 because there was a need for it, but I'm not sure if we have reasons to add all of the others in between sizes (sizes 500, 700, 900).

I added in the 500, 700 and 900 as there are areas where that value is hard-coded into the UIs or there are some other random uses.

Is there a harm in adding them or is there something else we need to do?

@leeejune
Copy link
Contributor

@blackfalcon Got it. No harm, but just concerned with having every spacing option for the designers in Figma. What do you think about keeping those in code only? I might need to think more about the implications of giving every single spacing option to designers.

@blackfalcon
Copy link
Member Author

What do you think about keeping those in code only? I might need to think more about the implications of giving every single spacing option to designers.

That's your call.

@leeejune
Copy link
Contributor

Will not add 500,700,900 in design. Ready for release in Figma.

@blackfalcon blackfalcon merged commit 8be3e7b into master Sep 27, 2022
@blackfalcon blackfalcon deleted the dsande/refactorspacing/71 branch September 27, 2022 18:07
@AuroDesignSystem
Copy link
Collaborator

🎉 This PR is included in version 3.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AuroDesignSystem AuroDesignSystem added the released Completed work has been released label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor size spacing values
4 participants