Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WCSS to support new tokens over deprecated #122

Merged
merged 6 commits into from
Oct 6, 2022

Conversation

blackfalcon
Copy link
Member

@blackfalcon blackfalcon commented Sep 26, 2022

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #121

Dependency:

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

The scope of this PR is to update WCSS so that it deprecates the legacy size tokens in favor of the new size ladder values.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Changes to be committed:
modified:   tests/roleButton.spec.scss
modified:   tests/roleTab.spec.scss
@blackfalcon blackfalcon linked an issue Sep 26, 2022 that may be closed by this pull request
Changes to be committed:
modified:   package.json
modified:   packageScripts/postinstall.js
Changes to be committed:
modified:   docs/index.html
@blackfalcon blackfalcon force-pushed the dsande/newtokens/121 branch 2 times, most recently from 88044b5 to 2993dd9 Compare September 27, 2022 15:29
@blackfalcon blackfalcon requested a review from a team September 27, 2022 15:32
@blackfalcon blackfalcon marked this pull request as ready for review September 27, 2022 18:26
@blackfalcon blackfalcon force-pushed the dsande/newtokens/121 branch 2 times, most recently from 13ee835 to 85c008d Compare October 6, 2022 17:16
Changes to be committed:
modified:   package-lock.json
modified:   package.json
Changes to be committed:
modified:   packageScripts/postinstall.js
@blackfalcon blackfalcon merged commit e4ed90c into master Oct 6, 2022
@blackfalcon blackfalcon deleted the dsande/newtokens/121 branch October 6, 2022 20:53
@blackfalcon
Copy link
Member Author

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update WCSS to use new size tokens
2 participants