Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update token names for theming support #229

Closed
jordanjones243 opened this issue Aug 8, 2023 · 1 comment · Fixed by #228
Closed

Update token names for theming support #229

jordanjones243 opened this issue Aug 8, 2023 · 1 comment · Fixed by #228
Assignees
@jordanjones243
Labels
auro-button Type: Feature New Feature

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Aug 8, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

With the work regarding the new theming conventions being adopted by the Auro and ITS teams, we need to update the tokens to incorporate the new design tokens from the AuroDesignTokens and JetstreamDesignTokens repos.

Describe the solution you'd like

Change the currently named prefixes of design tokens from --auro to --ds.

Describe alternatives you've considered

None.

Additional context

This work will be completed once the work items regarding theming from the AuroDesignTokens and JetstreamDesignTokens are completed:
@jordanjones243 jordanjones243 added Type: Feature New Feature not-reviewed Issue has not been reviewed by Auro team member auro-button labels Aug 8, 2023
@jordanjones243 jordanjones243 self-assigned this Aug 8, 2023
@jordanjones243 jordanjones243 linked a pull request Aug 8, 2023 that will close this issue
Update tokens based on new theming convention #228
Merged
6 tasks
@blackfalcon blackfalcon removed their assignment Aug 9, 2023
@jordanjones243 jordanjones243 mentioned this issue Aug 8, 2023
Merged
6 tasks
jordanjones243 added a commit that referenced this issue Aug 28, 2023
@jordanjones243
perf(token): update design token names #229
b393d2d
jordanjones243 added a commit that referenced this issue Sep 13, 2023
@jordanjones243
perf(token): update design token names #229
03dbdac
jordanjones243 added a commit that referenced this issue Sep 13, 2023
@jordanjones243
perf(token): update design token names #229
a98e61c
@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team member label Sep 14, 2023
jordanjones243 added a commit that referenced this issue Nov 4, 2023
@jordanjones243
perf(token): update design token names #229
f67e59a
@jordanjones243 jordanjones243 mentioned this issue Nov 4, 2023
Closed
@jordanjones243 jordanjones243 changed the title Update the design token names used in stylesheets Update token names for theming support Nov 4, 2023
jordanjones243 added a commit that referenced this issue Nov 4, 2023
@jordanjones243
perf(token): update design token names #229
7740e59
jordanjones243 added a commit that referenced this issue Nov 14, 2023
@jordanjones243
perf(token): update design token names #229
385d0fb
jordanjones243 added a commit that referenced this issue Nov 14, 2023
@jordanjones243
perf(token): update design token names #229
397707e
jordanjones243 added a commit that referenced this issue Dec 4, 2023
@jordanjones243
perf(tokens): add css fallbacks for tokens #229
6462dbb
jordanjones243 added a commit that referenced this issue Dec 4, 2023
@jordanjones243
fix(tokens): replace invalid tokens #229
965ebf6
@jordanjones243
Copy link
Contributor Author

Moving this ticket as blocked, as one of the tokens being used in the style code no longer exists and a new token will need to be created. A link to the ticket will be added as a part of this thread when created.

@jordanjones243 jordanjones243 mentioned this issue Dec 5, 2023
Closed
jordanjones243 added a commit that referenced this issue Dec 29, 2023
@jordanjones243
perf(token): update design token names #229
06b2f71
jordanjones243 added a commit that referenced this issue Dec 29, 2023
@jordanjones243
perf(tokens): add css fallbacks for tokens #229
d321929
jordanjones243 added a commit that referenced this issue Dec 29, 2023
@jordanjones243
fix(tokens): replace invalid tokens #229
7998934
jordanjones243 added a commit that referenced this issue Jan 2, 2024
@jordanjones243
perf(token): update design token names #229
f94ab5d
jordanjones243 added a commit that referenced this issue Jan 2, 2024
@jordanjones243
perf(tokens): add css fallbacks for tokens #229
423502b
jordanjones243 added a commit that referenced this issue Jan 2, 2024
@jordanjones243
fix(tokens): replace invalid tokens #229
7652913
blackfalcon pushed a commit that referenced this issue Jan 2, 2024
@semantic-release-bot
chore(release): 7.2.2 [skip ci]
62b3c76 
## [7.2.2](v7.2.1...v7.2.2) (2024-01-02)

### Bug Fixes

* **demo:** update surge demo branch ([5393ed9](5393ed9))
* **marked:** update marked package to script ([9ad605c](9ad605c))
* **tokens:** replace invalid tokens [#229](#229) ([7652913](7652913))

### Performance Improvements

* **accordion:** use new version of accordion ([eba6c1e](eba6c1e))
* **alert:** update to use auro-alert ([e18015c](e18015c))
* **deps:** update dependencies ([7daaf28](7daaf28))
* **eslint:** install auro eslint rules ([d9fd3ed](d9fd3ed))
* **focus:** remove focus-visible support ([c0511e5](c0511e5))
* **hover:** update hover css rules ([f64446d](f64446d))
* **hover:** update secondary hover color [#227](#227) ([1eff68d](1eff68d))
* **hover:** update tertiary hover color [#236](#236) ([2d346fa](2d346fa))
* **jsdocs:** update jsdocs ([ebec779](ebec779))
* **node:** update to support node 20 ([816d29e](816d29e))
* **tokens:** add css fallbacks for tokens [#229](#229) ([423502b](423502b))
* **token:** update design token names [#229](#229) ([f94ab5d](f94ab5d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
auro-button Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update tokens based on new theming convention AlaskaAirlines/auro-button
4 participants
@blackfalcon @jason-capsule42 @jordanjones243 @Patrick-Daly-AA