Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tokens based on new theming convention #228

Merged
merged 16 commits into from
Jan 2, 2024
Merged

Update tokens based on new theming convention #228

merged 16 commits into from
Jan 2, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Aug 8, 2023 •
edited

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #227, #229, #236

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

  • Update token names to use new --ds prefix
  • Update dependencies
  • Update to support Node 20
  • Update branch references
  • Incorporate the use of the updated auro-alert
  • Update hover colors to use linear gradient
  • Update JSDocs
  • Remove focus-visible support

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jordanjones243 jordanjones243 self-assigned this Aug 8, 2023
@jordanjones243 jordanjones243 linked an issue Aug 8, 2023 that may be closed by this pull request
Update token names for theming support #229
Closed
@github-actions
Copy link

github-actions bot commented Sep 5, 2023 •
edited

Surge demo deployment succeeded! 🚀🚀🚀

Auro Web Component Generator

@jordanjones243 jordanjones243 force-pushed the jordanjones243/updateTokens branch 2 times, most recently from d6397f1 to c15c5d9 Compare September 5, 2023 22:28
@jordanjones243 jordanjones243 force-pushed the jordanjones243/updateTokens branch 2 times, most recently from 2baf7d6 to 9c113cf Compare September 13, 2023 07:50
@jordanjones243 jordanjones243 marked this pull request as ready for review September 13, 2023 07:50
@jordanjones243 jordanjones243 requested a review from a team as a code owner September 13, 2023 07:50
@jordanjones243 jordanjones243 marked this pull request as draft September 14, 2023 15:10
@jordanjones243 jordanjones243 force-pushed the jordanjones243/updateTokens branch 2 times, most recently from 5724082 to 1be098c Compare November 4, 2023 22:19
@jordanjones243 jordanjones243 force-pushed the jordanjones243/updateTokens branch 2 times, most recently from f7cc347 to 3e68186 Compare November 4, 2023 22:20
@jordanjones243 jordanjones243 marked this pull request as ready for review November 4, 2023 22:21
@pgm369 pgm369 linked an issue Nov 7, 2023 that may be closed by this pull request
Hover state color to be changed #227
Closed
blackfalcon
blackfalcon requested changes Nov 10, 2023
View reviewed changes
.github/settings.yml Outdated Show resolved Hide resolved
.github/workflows/publishDemo.yml Show resolved Hide resolved
demo/api.html Outdated Show resolved Hide resolved
demo/api.html Outdated Show resolved Hide resolved
demo/index.html Outdated Show resolved Hide resolved
demo/index.html Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@jordanjones243 jordanjones243 force-pushed the jordanjones243/updateTokens branch 3 times, most recently from a634cb2 to be18839 Compare November 14, 2023 19:36
blackfalcon
blackfalcon previously requested changes Nov 29, 2023
View reviewed changes
src/style.scss Outdated Show resolved Hide resolved
jason-capsule42
jason-capsule42 previously requested changes Dec 5, 2023
View reviewed changes
demo/api.md Show resolved Hide resolved
src/style.scss Outdated Show resolved Hide resolved
src/style.scss Outdated Show resolved Hide resolved
src/style.scss Outdated Show resolved Hide resolved
src/style.scss Outdated Show resolved Hide resolved
@leeejune leeejune mentioned this pull request Dec 6, 2023
Closed
5 tasks
@jordanjones243 jordanjones243 marked this pull request as ready for review December 29, 2023 19:41
jason-capsule42
jason-capsule42 reviewed Dec 30, 2023
View reviewed changes
src/style.scss Show resolved Hide resolved
src/style.scss
color: rgba($auro-color-text-link-on-light, $disabledOPacity);
background-color: rgba($auro-color-background-lightest, $disabledOPacity);
border: 1px solid rgba($auro-color-ui-default-on-light, $disabledOPacity);
color: rgba($ds-color-text-link-default, $disabledOPacity);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These colors that don't use tokens are not able top be themed. Wasn't part of this work intended to get new tokens so at least all colors are theme-able?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding, these variables are being consumed from our sass variables, so they should still be theme-able if an implementer creates their own sass files with their own values.

@jordanjones243 jordanjones243 marked this pull request as draft January 2, 2024 17:49
@jason-capsule42
Copy link
Member

This PR is approved pending @jordanjones243 opening a ticket for the non-themeable opacity colors called out in earlier comments.

@jordanjones243
Copy link
Contributor Author

This PR is approved pending @jordanjones243 opening a ticket for the non-themeable opacity colors called out in earlier comments.

The issue for this problem has been created:

@jordanjones243 jordanjones243 marked this pull request as ready for review January 2, 2024 20:07
@jordanjones243 jordanjones243 dismissed stale reviews from jason-capsule42 and blackfalcon January 2, 2024 20:08

All comments have been addressed

@jordanjones243 jordanjones243 merged commit ebec779 into master Jan 2, 2024
5 checks passed
@jordanjones243 jordanjones243 deleted the jordanjones243/updateTokens branch January 2, 2024 20:09
@blackfalcon
Copy link
Member

🎉 This PR is included in version 7.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Jan 2, 2024
@jordanjones243 jordanjones243 linked an issue Jan 3, 2024 that may be closed by this pull request
auro-button: update on-dark tertiary button hover color #236
Closed
@jordanjones243 jordanjones243 mentioned this pull request Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeejune leeejune leeejune approved these changes

@blackfalcon blackfalcon Awaiting requested review from blackfalcon

@jason-capsule42 jason-capsule42 Awaiting requested review from jason-capsule42

Assignees

@jordanjones243 jordanjones243

Labels
released Completed work has been released
Projects
None yet
Milestone
No milestone
5 participants
@jordanjones243 @jason-capsule42 @blackfalcon @leeejune @pgm369