fix: issue on dependencies auro--select for matchWidth for the value to much long #217
Conversation
irma-kurnia-alaska
force-pushed
the
irmaku/truncatedText
branch
2 times, most recently
from
b817ab9
to
0c3c853
Compare
blackfalcon
force-pushed
the
irmaku/truncatedText
branch
from
0c3c853
to
5bfc188
Compare
irma-kurnia-alaska
force-pushed
the
irmaku/truncatedText
branch
from
5bfc188
to
72f3244
Compare
fajar-apri-alaska
force-pushed
the
irmaku/truncatedText
branch
from
e035d40
to
a87d4b5
Compare
fajar-apri-alaska
force-pushed
the
irmaku/truncatedText
branch
from
a87d4b5
to
b8cc2e4
Compare
| import { fileURLToPath } from 'url'; | ||
|
|
||
| const __dirname = new URL('.', import.meta.url).pathname; | ||
| const __dirname = fileURLToPath(new URL('.', import.meta.url)); |
There was a problem hiding this comment.
This file is coming from a template that all components use and individual components should not diverge.
Is there a case why this change is necessary for this issue?
There was a problem hiding this comment.
@jason-capsule42, in my case, it doesn't work on my machine.
I have something like home/fajar/Git Project/auro-dropdown local path. When I ran the old script, it returns home/fajar/Git%20Project/auro-dropdown and somehow it couldn't find the path it refer to.
I already asked Dale about this as well, He said it is fine to change that.
Reference: AlaskaAirlines/auro-radio@2fcaa20
There was a problem hiding this comment.
Let't not make this change as a one off just to this component repo. @jordanjones243 @blackfalcon what do you think about this proposed change to the script. Is this something you think makes sense to change to all the generateDocs.js files in all components?
…ext to much long Change to be committed: modified: package.json modified: src/style.scss
Change to be committed: new fille: apiExamples/truncatedText.html modified: demo/demo.md modified: docs/partials/demo.md
- update to __dirname declaration to also work on MacOS machines. Changes to be committed: modified: scripts/generateDocs.mjs
Changes to be committed: modified: apiExamples/truncatedText.html modified: demo/demo.md modified: docs/partials/demo.md
irma-kurnia-alaska
force-pushed
the
irmaku/truncatedText
branch
from
b8cc2e4
to
a276b2b
Compare
Change to be committed: modified: demo/api.md modified: demo/index.md modified: docs/partials/api.md modified: docs/partials/index.md
|
🎉 This PR is included in version 2.10.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: Demo for flexible width containers #101
Summary:
I attached the screenshot in my local base the modified:
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team