Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve marking js code #196

Closed
jordanjones243 opened this issue Feb 28, 2024 · 1 comment · Fixed by #197
Closed

Improve marking js code #196

jordanjones243 opened this issue Feb 28, 2024 · 1 comment · Fixed by #197
Assignees
@jordanjones243
Labels
auro-menu Type: Feature New Feature

Comments

@jordanjones243
Copy link
Contributor

General Support Request

Improve logic behind marking menu options logic to avoid errors

Possible Solution

Wrap the code in the function around an if statement

Additional context

An issue with this logic came up when working on auro-combobox's dynamic menu example

Exit criteria

The error from the example no longer exists
@jordanjones243 jordanjones243 self-assigned this Feb 28, 2024
jordanjones243 added a commit that referenced this issue Mar 1, 2024
@jordanjones243
perf(mark): improve marking logic to avoid error #196
8c54c5c
@jordanjones243 jordanjones243 mentioned this issue Mar 1, 2024
Merged
6 tasks
jordanjones243 added a commit that referenced this issue Mar 1, 2024
@jordanjones243
perf(mark): improve marking logic to avoid error #196
7f92b81
blackfalcon pushed a commit that referenced this issue Mar 1, 2024
@semantic-release-bot
chore(release): 3.11.4 [skip ci]
39ffd11 
## [3.11.4](v3.11.3...v3.11.4) (2024-03-01)

### Performance Improvements

* **mark:** improve marking logic to avoid error [#196](#196) ([7f92b81](7f92b81))
@jordanjones243 jordanjones243 linked a pull request Mar 5, 2024 that will close this issue
Improve marking logic to avoid error #197
Merged
6 tasks
@jordanjones243
Copy link
Contributor Author

This work was completed in this PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
auro-menu Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve marking logic to avoid error AlaskaAirlines/auro-menu
2 participants
@jordanjones243 @Patrick-Daly-AA