Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve marking logic to avoid error #197

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

jordanjones243
Copy link
Contributor

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #196

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Add if statement to mark logic in to avoid errors on this.items

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jordanjones243 jordanjones243 self-assigned this Mar 1, 2024
@jordanjones243 jordanjones243 requested a review from a team as a code owner March 1, 2024 03:54
@jordanjones243 jordanjones243 marked this pull request as draft March 1, 2024 03:54
@jordanjones243 jordanjones243 marked this pull request as ready for review March 1, 2024 20:24
@jordanjones243 jordanjones243 merged commit 7f92b81 into main Mar 1, 2024
6 checks passed
@jordanjones243 jordanjones243 deleted the jjones/improveLogic/#196 branch March 1, 2024 20:24
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.11.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Mar 1, 2024
@jordanjones243 jordanjones243 linked an issue Mar 5, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve marking js code
2 participants