Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-menu: menu text weight incorrect #6

Closed
Tracked by #22
erikalanghauser opened this issue May 24, 2021 · 1 comment · Fixed by #46
Closed
Tracked by #22

auro-menu: menu text weight incorrect #6

erikalanghauser opened this issue May 24, 2021 · 1 comment · Fixed by #46
Labels
auro-menu Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes
Projects
Auro (general board)
Milestone
auro-menu v3.0-rc

Comments

@erikalanghauser
Copy link
Member

Describe the bug

The text for the menu options in auro-menu is too bold and does not match our auro body-default weight which is Book weight.
auro.alaskaair.com says var(--auro-text-body-default-weight) = 500

auro-menu/src/style.scss

Line 34 in 7c5a05f

font-weight: 600;
shows weight of 600.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://flightsearch-lem.w2.ecomm-test-aks.alaskaair.com/sea/lim/16may
  2. Click into any of the filter dropdowns.
  3. The text is too bold and does not match our auro body-default which is Book weight (500).

Expected behavior

I expect the menu items to have default body weight & size.

Screenshots

Menu design screenshot using var(--auro-text-body-size-default)
image

Menu in code, text is too thick
image

Desktop (please complete the following information):

  • OS: Mac
  • Browser chrome
  • Version 90.0.4430.212 (Official Build) (x86_64)

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Add any other context about the problem here.
@erikalanghauser erikalanghauser added the Type: Bug Bug or Bug fixes label May 24, 2021
@erikalanghauser
Copy link
Member Author

@bridgetglewis

@blackfalcon blackfalcon added this to Backlog in Auro (general board) via automation May 24, 2021
@braven112 braven112 mentioned this issue Sep 13, 2021
Closed
11 tasks
@blackfalcon blackfalcon added this to the v.2.0-rc milestone Sep 13, 2021
@braven112 braven112 mentioned this issue Dec 14, 2021
Closed
@blackfalcon blackfalcon modified the milestones: v.2.0-rc, v3.0-rc Dec 15, 2021
blackfalcon added a commit that referenced this issue Dec 21, 2021
@blackfalcon
fix(style): adjust font weight #6
06663a5 
Changes to be committed:
modified:   src/style.scss
@blackfalcon blackfalcon mentioned this issue Dec 21, 2021
Merged
6 tasks
@blackfalcon blackfalcon linked a pull request Dec 21, 2021 that will close this issue
Adjust text weight #46
Merged
6 tasks
@blackfalcon blackfalcon added the Status: Work In Progress Issue or Pull Request work is in Progress label Dec 21, 2021
blackfalcon added a commit that referenced this issue Dec 21, 2021
@blackfalcon
fix(style): adjust font weight #6
748871c 
Changes to be committed:
modified:   src/style.scss
blackfalcon added a commit that referenced this issue Dec 21, 2021
@blackfalcon
fix(style): adjust font weight #6
60411be 
Changes to be committed:
modified:   src/style.scss
Auro (general board) automation moved this from Backlog to Done/Deployed/Closed Dec 21, 2021
blackfalcon added a commit that referenced this issue Jan 11, 2022
@blackfalcon
fix(style): adjust font weight #6
3cb57e5 
Changes to be committed:
modified:   src/style.scss
blackfalcon added a commit that referenced this issue Jan 22, 2022
@blackfalcon
fix(style): adjust font weight #6
d652c82 
Changes to be committed:
modified:   src/style.scss
blackfalcon pushed a commit that referenced this issue Jan 22, 2022
@semantic-release-bot
chore(release): 2.2.0 [skip ci]
1b0a514 
# [2.2.0](v2.1.0...v2.2.0) (2022-01-22)

### Bug Fixes

* **a11y:** address event firing from keyboard ([d4fbe92](d4fbe92))
* **css:** address ui issues from review ([bfe54ff](bfe54ff))
* **dom template:** remove unnecessary DOM; address ellipsis feature ([20cf785](20cf785))
* **style:** adjust font weight [#6](#6) ([d652c82](d652c82))

### Features

* **disabled:** add support for disabled menu option [#25](#25) ([1cc08d4](1cc08d4))
* **hr:** add support for hr ui [#70](#70) ([c7f89da](c7f89da))

### Performance Improvements

* **icon:** update to support direct dependency with icon ([e50de2b](e50de2b))
* **mdmagic:** reduce scope of mdmagic docs ([cac8a84](cac8a84))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auro-menu Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes
Projects
Auro (general board)
  
Done/Deployed/Closed
Milestone
auro-menu v3.0-rc
Development

Successfully merging a pull request may close this issue.

Adjust text weight AlaskaAirlines/auro-menu
3 participants
@blackfalcon @BrentLabasan @erikalanghauser