Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion with divider reference? #70

Closed
blackfalcon opened this issue Jan 20, 2022 · 1 comment · Fixed by #73
Closed

Confusion with divider reference? #70

blackfalcon opened this issue Jan 20, 2022 · 1 comment · Fixed by #73
Assignees
Labels

Comments

@blackfalcon
Copy link
Member

General Support Request

In the Figma file, there is a divider reference with each individual representation

Screen Shot 2022-01-20 at 9 32 08 AM

Support request

There is no divider between each node in the full menu image (below). In the image above, there is an arrow pointing to the bottom of each node designating that there should be a divider line between each option?

Screen Shot 2022-01-20 at 9 37 46 AM

Also, please advise as to how many dividers need to appear when there is a sub-menu. The image above shows one, but the image below shows two?

Screen Shot 2022-01-20 at 9 39 05 AM

@leeejune
Copy link
Contributor

There is no divider between each node in the full menu image (below). In the image above, there is an arrow pointing to the bottom of each node designating that there should be a divider line between each option?

The first part with a divider for each option is just for demonstration purposes. Each option COULD have a divider, but is not required.

Also, please advise as to how many dividers need to appear when there is a sub-menu. The image above shows one, but the image below shows two?

Dividers are completely optional. In the image above, there is just one because it is closer to what it would look like if a designer is using menu. The image below has an extra divider on the bottom just for spacing demonstration purposes.

@blackfalcon blackfalcon linked a pull request Jan 21, 2022 that will close this issue
6 tasks
@blackfalcon blackfalcon assigned blackfalcon and unassigned leeejune Jan 21, 2022
@blackfalcon blackfalcon added Status: Work In Progress Issue or Pull Request work is in Progress Type: Feature New Feature and removed Type: Design New or related Design work labels Jan 21, 2022
blackfalcon added a commit that referenced this issue Jan 21, 2022
Changes to be committed:
modified:   demo/demo.md
modified:   src/style-base.scss
@blackfalcon blackfalcon removed the Status: Work In Progress Issue or Pull Request work is in Progress label Jan 21, 2022
blackfalcon added a commit that referenced this issue Jan 21, 2022
Changes to be committed:
modified:   demo/demo.md
modified:   src/style-base.scss
blackfalcon added a commit that referenced this issue Jan 22, 2022
Changes to be committed:
modified:   demo/demo.md
modified:   src/style-base.scss
blackfalcon pushed a commit that referenced this issue Jan 22, 2022
# [2.2.0](v2.1.0...v2.2.0) (2022-01-22)

### Bug Fixes

* **a11y:** address event firing from keyboard ([d4fbe92](d4fbe92))
* **css:** address ui issues from review ([bfe54ff](bfe54ff))
* **dom template:** remove unnecessary DOM; address ellipsis feature ([20cf785](20cf785))
* **style:** adjust font weight [#6](#6) ([d652c82](d652c82))

### Features

* **disabled:** add support for disabled menu option [#25](#25) ([1cc08d4](1cc08d4))
* **hr:** add support for hr ui [#70](#70) ([c7f89da](c7f89da))

### Performance Improvements

* **icon:** update to support direct dependency with icon ([e50de2b](e50de2b))
* **mdmagic:** reduce scope of mdmagic docs ([cac8a84](cac8a84))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants