-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusion with divider reference? #70
Comments
The first part with a divider for each option is just for demonstration purposes. Each option COULD have a divider, but is not required.
Dividers are completely optional. In the image above, there is just one because it is closer to what it would look like if a designer is using menu. The image below has an extra divider on the bottom just for spacing demonstration purposes. |
Changes to be committed: modified: demo/demo.md modified: src/style-base.scss
Changes to be committed: modified: demo/demo.md modified: src/style-base.scss
Changes to be committed: modified: demo/demo.md modified: src/style-base.scss
# [2.2.0](v2.1.0...v2.2.0) (2022-01-22) ### Bug Fixes * **a11y:** address event firing from keyboard ([d4fbe92](d4fbe92)) * **css:** address ui issues from review ([bfe54ff](bfe54ff)) * **dom template:** remove unnecessary DOM; address ellipsis feature ([20cf785](20cf785)) * **style:** adjust font weight [#6](#6) ([d652c82](d652c82)) ### Features * **disabled:** add support for disabled menu option [#25](#25) ([1cc08d4](1cc08d4)) * **hr:** add support for hr ui [#70](#70) ([c7f89da](c7f89da)) ### Performance Improvements * **icon:** update to support direct dependency with icon ([e50de2b](e50de2b)) * **mdmagic:** reduce scope of mdmagic docs ([cac8a84](cac8a84))
General Support Request
In the Figma file, there is a divider reference with each individual representation
Support request
There is no divider between each node in the full menu image (below). In the image above, there is an arrow pointing to the bottom of each node designating that there should be a divider line between each option?
Also, please advise as to how many dividers need to appear when there is a sub-menu. The image above shows one, but the image below shows two?
The text was updated successfully, but these errors were encountered: