Custom/server validation errors #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to set custom errors using validatAll(). While setError() and setErrors() allow for setting custom errors, subsequently running validateAll() will clear them and set only the internally generated formLinker errors. Consequently, scrollToError(), which relies on validateAll() to generate validation errors, can't scroll to a custom error.
This PR adds the ability for validateAll() to optionally take an errors object as its argument and it will merge those errors with the formLinker generated errors. scrollToError() can also take an errors object argument which it will pass to validateAll().
This PR has no breaking changes.