Refactor admin pages controller spec #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtomov
reviewed
Mar 24, 2017
| alchemy_post :publish, { id: page.id } | ||
| expect { | ||
| post publish_admin_page_path(page) | ||
| }.to change { page.reload.published_at } | ||
| end |
There was a problem hiding this comment.
My suggestion here for MySQL is:
# spec/requests/alchemy/admin/pages_controller_spec.rb:666
- let(:page) { create(:alchemy_page) }
+ let(:page) { create(:alchemy_page, published_at: 3.days.ago) }edit that should actually fix the only failing spec and get this build to a green one.
else super 👍 !
There was a problem hiding this comment.
Feel free to actually directly cherry-pick that:
The controller spec was bogus. A feature spec for testing what the instance variable actually effects in thew views is preferable.
Rails 5 removes controller specs and request specs are preferred. This also refactors lots of heavy stubbing out of this spec.
- as MySQL only saves times to the db in seconds precision
tvdeyen
force-pushed
the
refactor-admin-pages-controller-spec
branch
from
739a6bd
to
97a7130
Compare
houndci-bot
reviewed
Jun 20, 2017
|
|
||
| it "should publish the page" do | ||
| expect(page).to receive(:publish!) | ||
| alchemy_post :publish, { id: page.id } | ||
| expect { |
There was a problem hiding this comment.
Parenthesize the param change { page.reload.published_at } to make sure that the block will be associated with the change method call.
| } | ||
| end | ||
|
|
||
| context "a new page" do |
|
Merging this ignoring hound here for now. I opened another PR that fixes all rubocop issues, but this is rather large, so it will take some time to review. |
|
Merging even though Hound complains, we're fixing the Hound configuration in #1267 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more Rails 5 related fixes for the test suite.