Only crop image if cropping is enabled #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
only-crop-if-enabled
branch
from
636603d
to
f9ddbf6
Compare
Before we enabled cropping even if cropping was disabled only because we had crop values in the database. This is confusing, inconsistent and error prone. Imagine an essence picture having crop values, but the image cropper is disabled because the element settings has been changed. The image was still be cropped in those cases. Now cropping has to be explicitely enabled in the element settings to crop an image, regardless of the database state.
tvdeyen
force-pushed
the
only-crop-if-enabled
branch
from
f9ddbf6
to
5474ff4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Before we enabled cropping even if cropping was disabled only because we had crop values in the database. This is confusing, inconsistent and error prone. Imagine an essence picture having crop values, but the image cropper is disabled because the element settings has been changed. The image was still be cropped in those cases, leaving the editor no control over the cropped area.
Now cropping has to be explicitly enabled in the element settings to crop an image, regardless of the database state.
Checklist