Rails 7 Support #2225
Merged
Rails 7 Support #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
any update on the plans for releasing it? |
But do not test Rails 7 with Ruby 2.6, because they dropped support for it.
Rails 7 does not autoload constants during boot anymore.
Now that the userclass will be set in a config.to_prepare block in apps we need to run this code last.
Nope. Sorry, "it's done when it's done"™️. If you want to help, please provide PRs against this branch. |
To make this feature work we added a Hack into active record. This hack does not work in Rails 7 anymore. Since contents with essences are deprecated anyway and we do not have this problem with ingredients it is not worth adjusting the hack to active record 7 This reverts commit c45a6dd
We need this until a Rails 7.0 version has been released to includes the fix for MySQL foreign keys rails/rails#42350
This spec needs to be adopted to latest Rails versions.
This stopped working in Rails 7. Since Rails 5.2 it is possible to allow other hosts in redirect_to. Since this is a admin controller this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Adds support for Rails 7
Breaking changes
This removes support for eager loading
ingredient_associationfrom essence classes introduced in c45a6ddCloses #2224
Need stable version from at least these gems
The list is very likely incomplete yet.
Checklist