[6.1] Picture Ingredient: Fix NaN error with free height #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When indicating that a picture can be cropped, but needs to have a certain height or width but leaves the other dimension free, current Alchemy throws a `NaN` error because of float division by Zero. This commit handles this case by returning nil if the calculated mask is Not a Number.
mamhoff
force-pushed
the
6.1-fix-nan-ratio-error
branch
from
a8f9e12
to
23be95a
Compare
|
Closed in favor of an automate backporting tool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
When indicating that a picture can be cropped, but needs to have a certain height or width but leaves the other dimension free, current Alchemy throws a
NaNerror because of float division by Zero.This commit handles this case by returning nil if the calculated mask is Not a Number.
Backport of #2556
Notable changes (remove if none)
None
Screenshots
See #2556
Checklist