Touch parent while sorting nestable elements #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For performance reasons we update the position of elements directly into database and skip activerecord callbacks. This breaks the touching mechanisms of activerecord. We need to ensure that the parent element (if any) gets touched to invalidate it's cache key. Fixes #991
|
I've prepared a stage to preview changes. Open stage or view logs. |
|
Changelog entry is missing |
|
We don't need a change log entry for fixing a feature that is introduced in the same version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For performance reasons we update the position of elements
directly into database and skip activerecord callbacks.
This breaks the touching mechanisms of activerecord. We need
to ensure that the parent element (if any) gets touched to
invalidate it's cache key.
Fixes #991