#3: WPF demo does not show a dark title bar, fails on CI but not locally

Aldaviva · Oct 5, 2022 · 60696c9 · 60696c9
1 parent 7c5e354
commit 60696c9
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 14 deletions.
diff --git a/DarkNet/DarkNet.cs b/DarkNet/DarkNet.cs
@@ -39,7 +39,8 @@ public class DarkNet: IDarkNet {
     private bool?  _userDefaultAppThemeIsDark;
     private bool?  _userTaskbarThemeIsDark;
     private Theme? _preferredAppMode;
-    private int    _processThemeChanged; // int instead of bool to support Interlocked atomic operations
+
+    private volatile int _processThemeChanged; // int instead of bool to support Interlocked atomic operations
 
     /// <inheritdoc />
     public event EventHandler<bool>? UserDefaultAppThemeIsDarkChanged;
@@ -146,7 +147,7 @@ public class DarkNet: IDarkNet {
     }
 
     private void ImplicitlySetProcessThemeIfFirstCall(Theme theme) {
-        if (Interlocked.CompareExchange(ref _processThemeChanged, 1, 0) == 0) {
+        if (_processThemeChanged == 0) {
             SetCurrentProcessTheme(theme);
         }
     }

diff --git a/DarkNet/DarkNet.csproj b/DarkNet/DarkNet.csproj
@@ -2,7 +2,7 @@
 
     <PropertyGroup>
         <TargetFrameworks>netcoreapp3.1;net452</TargetFrameworks>
-        <Version>2.0.0</Version>
+        <Version>2.0.1</Version>
         <LangVersion>latest</LangVersion>
         <Nullable>enable</Nullable>
         <UseWindowsForms>true</UseWindowsForms>

diff --git a/darknet-demo-wpf/Properties/PublishProfiles/FolderProfile.pubxml b/darknet-demo-wpf/Properties/PublishProfiles/FolderProfile.pubxml
@@ -3,15 +3,15 @@
 https://go.microsoft.com/fwlink/?LinkID=208121.
 -->
 <Project>
-    <PropertyGroup>
-        <Configuration>Release</Configuration>
-        <Platform>Any CPU</Platform>
-        <PublishDir>bin\Release\net6.0-windows\publish\win-x86\</PublishDir>
-        <PublishProtocol>FileSystem</PublishProtocol>
-        <TargetFramework>net6.0-windows</TargetFramework>
-        <RuntimeIdentifier>win-x86</RuntimeIdentifier>
-        <SelfContained>false</SelfContained>
-        <PublishSingleFile>true</PublishSingleFile>
-        <PublishReadyToRun>false</PublishReadyToRun>
-    </PropertyGroup>
+  <PropertyGroup>
+    <Configuration>Release</Configuration>
+    <Platform>Any CPU</Platform>
+    <PublishDir>bin\Release\net6.0-windows\win-x86\publish\</PublishDir>
+    <PublishProtocol>FileSystem</PublishProtocol>
+    <TargetFramework>net6.0-windows</TargetFramework>
+    <RuntimeIdentifier>win-x86</RuntimeIdentifier>
+    <SelfContained>false</SelfContained>
+    <PublishSingleFile>true</PublishSingleFile>
+    <PublishReadyToRun>false</PublishReadyToRun>
+  </PropertyGroup>
 </Project>