WPF demo does not show a dark title bar, fails on CI but not locally

[Aldaviva]

Affects version 2.0.0. Not sure why it's different, since it's the same SDK (.NET 6), similar OS (Windows 10 vs Server 2022), and codebase. The build command should be the same (dotnet publish). The Windows Forms demo is not affected.

Working and non-working artifacts

[Aldaviva]

This seems to be a difference between the packed binaries generated by MSBuild (local, working) and dotnet (not working).

A workaround is to explicitly call

DarkNet.Instance.SetWindowThemeWpf(this, Theme.Auto);

before any windows are shown.

I don't know if there are any additional arguments that can be passed to dotnet pack to make it work more like MSBuild.

[Aldaviva]

This was caused by a logical error in the implicit SetCurrentProcessTheme behavior introduced in 2.0.0. When invoked implicitly, it was never calling SetPreferredAppMode or AllowDarkModeForApp, even when it was being called for the first time and should have called at least one of those Win32 API methods. The root cause was marking this first-time call as having been finished too early, then checking it again before actually running it for the first time, and erroneously skipping it because it was marked as having already run, even though it hadn't.

I am not sure why the published app generated by Visual Studio and MSBuild did not reproduce this error, as the code flow was the same as the binary generated by dotnet publish.

In any case, fixing the first-run check makes it work for both compilers.

[Aldaviva]

Published to NuGet Gallery as 2.0.1.