Is this the right scale for PGS? And the PGS color in MadVR.

[Max33Verstappen]

Please check this video:
https://disk.yandex.com/d/2fmJw--pHq-nyQ

• 1st:
  The PGS in this video is rendered significantly larger than all other players and what it is on MPC-BE before 6f3b27b (tested on 1.6.2.7083 with "Position subtitles relative to the video frame" checked, so it's rendered on the video on that version, right?). Maybe because you swap the scale factor from scaleX = scaleY = videoAR < subtitleAR ? double(szTarget.cx) / m_virtualTextureSize.cx : double(szTarget.cy) / m_virtualTextureSize.cy; to something more or less equivalent to scaleX = scaleY = videoAR < subtitleAR ? double(szTarget.cy) / m_virtualTextureSize.cy : double(szTarget.cx) / m_virtualTextureSize.cx; to always get the larger one as the scaling factor while the old logic always get the smaller one?
  Was this done on purpose?

• 2nd:
  Please check the color of the subtitle in MadVR. The color of PGS subs is obvious "pale".
  No color space conversion for PGSs and so when using MadVR? Using MPCVR is fine. But other players are also fine in MadVR.

[Aleksoid1978]

1 - Compare with MPC-HC - the same size of PGS subtitles. PGS/DVB subtitles always renderer to the video frame.
2 - Player don't do any conversion for subtitle, it's just "send" this to video-renderer.
MPC VR just do some conversion when use HDR output.

[Max33Verstappen]

• 1st
  Please see my screenshot:
  MPC-HC:
  
  MPC-BE 1.6.2.7083 with "Position subtitles relative to the video frame" checked:
  
  MPC-BE (1.6.4.104):
  
  It's also larger in windowed mode.

• 2nd
  Then what's wrong?
  MPC-BE on MadVR:
  
  MPC-BE on MPCVR:
  
  PotPlayer on MadVR:
  
  MPC-HC:
  

The followings are more obvious: (Both on MadVR)
MPC-HC:

MPC-BE:

[Aleksoid1978]

1 - Yes i rewrited logic, PGC/DVB now always render inside video frame and not a window. If you zoom video - PGS subtitles also zoom.
2 - I don't know and can't help. Ask author madVR, he is have sources and can look/debug.

[Max33Verstappen]

For the 1st problem:
I know they're rendered to the video frame now. The screen shot I posted are all equivalent to rendering on the video frame (not relative to the window). I'm talking about the zoom factor of the PGS subs. Because the PGSs in this video have different AR than the video, so the following scaling code may involve, and you see in the new code videoAR < subtitleAR ? double(szTarget.cy) / m_virtualTextureSize.cy while in the old code it's videoAR < subtitleAR ? double(szTarget.cx) / m_virtualTextureSize.cx.
Which means they're now always pick the larger zoom factor, so I guess this is the reason why they're now appearing bigger?

On a video whose AR is equal to the PGS's AR, there's no such problem, because the above codes are not involved.

[Aleksoid1978]

I have no particular desire to get into this code again, to test hundreds of files with various subtitles.
If there is a desire - patch are welcome :)

[Aleksoid1978]

I compare with HC - the same size.

[Max33Verstappen]

I see.
It's all about AR and the choose of scaling factor.
The old MPC-BE always chooses the smaller scaling factor of the two:

Then new MPC-BE always chooses the larger scaling factor from two:

MPC-HC chooses the larger scaling factor when the Window AR < Video AR, and chooses the smaller scaling factor when the Window AR > Video AR

[Aleksoid1978]

I think that how it's in MPC-HC - it's not right. PGS/DVB subtitles must render as designed(position & size), but MPC-HC change size & position when sizing window.
So - you can use MPC-HC if needed.
Everything remains as it is - closed the topic.

[Max33Verstappen]

This actually seems to be a MPC-HC bug...
Moments ago, there's a new beta version, and it's been fixed.
Now it's the same as MPC-BE (use the larger scaling factor no matter how the AR changes).