feat: logging #2305
Closed
feat: logging #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardwu
reviewed
Jan 20, 2024
| @@ -36,7 +38,7 @@ impl<N: Network> Package<N> { | |||
| let _locator = Locator::<N>::from_str(&format!("{program_id}/{function_name}"))?; | |||
|
|
|||
| #[cfg(feature = "aleo-cli")] | |||
| println!("🚀 Running '{}'...\n", _locator.to_string().bold()); | |||
| trace!("🚀 Running '{}'...\n", _locator.to_string().bold()); | |||
There was a problem hiding this comment.
this is very wrong. the CLI does not use tracing!
There was a problem hiding this comment.
this has major downstream implications for leo
howardwu
reviewed
Jan 20, 2024
| @@ -400,7 +404,8 @@ mod tests { | |||
| check_true_sub_false_with_false(Mode::Public, Mode::Private, Mode::Constant, 0, 0, 2, 2); | |||
| check_true_sub_false_with_true(Mode::Public, Mode::Private, Mode::Constant, 0, 0, 3, 3); // <- Differs | |||
| check_true_sub_true_with_false(Mode::Public, Mode::Private, Mode::Constant, 0, 0, 2, 2); | |||
| check_true_sub_true_with_true(Mode::Public, Mode::Private, Mode::Constant, 0, 0, 3, 3); // <- Differs | |||
| check_true_sub_true_with_true(Mode::Public, Mode::Private, Mode::Constant, 0, 0, 3, 3); | |||
| // <- Differs | |||
There was a problem hiding this comment.
incorrect changes here, please fix, thanks!
howardwu
reviewed
Jan 20, 2024
| @@ -105,21 +106,21 @@ impl<F: PrimeField> LinearCombination<F> { | |||
| // Enforce property 2. | |||
| // Note: This branch is triggered if ANY term is not (zero or one). | |||
| if self.terms.iter().any(|(v, _)| !(v.value().is_zero() || v.value().is_one())) { | |||
| eprintln!("Property 2 of the `Boolean` type was violated in {self}"); | |||
| warn!("Property 2 of the `Boolean` type was violated in {self}"); | |||
There was a problem hiding this comment.
these warnings are meant to be eprintln
howardwu
reviewed
Jan 20, 2024
| @@ -156,6 +156,9 @@ optional = true | |||
| [dependencies.num-traits] | |||
| version = "0.2" | |||
|
|
|||
| [dependencies.log] | |||
There was a problem hiding this comment.
please remove usage of log
|
@howardwu was this closed by accident? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using println! for logging is annoying when snarkVM is used as library (like snarkOS).
Draft, to be revisited after mainnet.