feat: logging #2405
Closed
feat: logging #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## testnet3 #2405 +/- ##
============================================
+ Coverage 76.34% 76.35% +0.01%
============================================
Files 200 200
Lines 6742 6742
Branches 6742 6742
============================================
+ Hits 5147 5148 +1
+ Misses 1595 1594 -1 ☔ View full report in Codecov by Sentry. |
joske
force-pushed
the
testnet3
branch
2 times, most recently
from
1484f7c
to
026524d
Compare
|
@joske is this PR still relevant? |
|
I think this is still relevant, but it depends on the snarkVM PR or it will break things. The PRs has gotten stale/conflicted though, I'll try to rebase the PRs to latest upstream versions. |
|
Keeping this as a draft until after mainnet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use logging primitives instead of println!
Related PRs
https://github.com/AleoHQ/snarkVM/pull/2305