Implements hash_to_curve and samples generators for BLS12-377 and BW6-761
#241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 5, 2021 17:41
…nto feat/hash_to_curve
…nto feat/hash_to_curve
…nto feat/hash_to_curve
|
There is a bug in the |
…arkVM into feat/hash_to_curve
…eat/hash_to_curve
added 2 commits
July 11, 2021 22:15
emmorais
approved these changes
Jul 12, 2021
howardwu
commented
Jul 12, 2021
Pratyush
reviewed
Jul 12, 2021
Pratyush
reviewed
Jul 12, 2021
Pratyush
reviewed
Jul 12, 2021
Pratyush
reviewed
Jul 12, 2021
Pratyush
reviewed
Jul 12, 2021
added 7 commits
July 12, 2021 17:20
weikengchen
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
The code looks good.
I personally prefer more constant-time hashing-to-curve, since random point searching has a probability of failure (though negligible) and can sometimes be slow.
But implementing those maps, especially efficiently, is hard and burdensome. I support the Blake2xs approach.
added 2 commits
July 13, 2021 21:13
…t/hash_to_curve
…t/hash_to_curve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR implements Blake2Xs and uses it to implement
hash_to_curve. The generators for BLS12-377 and BW6-761 are sampled and updated usingtry_hash_to_curve.Unit tests checking the correspondence between the input message and generated point, as well as the BigInteger representation are provided.
This PR fixes #164, closing the loop on the BLS12-377 generator bug.