feat(SBFTree): added operators logic in SBFTree #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need implementation downward the nodes (Lead and Node)
Added additional utils methods needed findAll, findAllInLeaf + some more tests
Alex-Werner
force-pushed
the
feat/comparators
branch
from
8c0a730
to
cdf818e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or implemented
Right now, we are only able to perform strict comparison with our find method.
We need to be able to findAll, and find with specific operators.
What was done
Notes
We did not decide to just sequentially add our elements starting from our match. But it might would have been a good solution.
Let us put that in our mind as a potential improvement later on.
Reviewer notes :
Extra care needed on internode leaf, as our test only covers an order or 3 with 3 data. Improvement needed there too.