Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add atomic module to bee-transaction #238

Merged
merged 76 commits into from
Oct 6, 2020
Merged

Add atomic module to bee-transaction #238

merged 76 commits into from
Oct 6, 2020

Conversation

wusyong
Copy link
Contributor

@wusyong wusyong commented Sep 23, 2020 •
edited

This PR add a atomic module that contains types described in Message, Signed Transaction Payload, and Bech32 Address RFCs

pvdrz
pvdrz reviewed Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@pvdrz pvdrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I left some (slightly pedantic) comments. You can ignore them if you like :p

bee-transaction/src/atomic/message.rs Outdated Show resolved Hide resolved
bee-transaction/src/atomic/mod.rs Show resolved Hide resolved
bee-transaction/src/atomic/payload/milestone.rs Outdated Show resolved Hide resolved
bee-transaction/src/atomic/payload/signed_data.rs Outdated Show resolved Hide resolved
bee-transaction/src/atomic/payload/signed_transaction/mod.rs Outdated Show resolved Hide resolved
bee-transaction/src/atomic/payload/signed_transaction/unsigned_transaction.rs Outdated Show resolved Hide resolved
Finance and others added 24 commits October 5, 2020 10:50
@thibault-martinez
Initial draft
24cb600
@thibault-martinez
Add syntactical validation
0bfe5b9
@thibault-martinez
Add lexicographical order validation
a5ba0c7
@thibault-martinez
Add signed transaction builder
ced06f9
@thibault-martinez
Derive default trait instead of new
d271e18
@thibault-martinez
Update type of WotsAddress
7338363
@thibault-martinez
Add bincode serialization for Input
b35ea0e
@thibault-martinez
Add serialization for Output
281f8b9
@thibault-martinez
Fix input field name
48c6584
@thibault-martinez
Add signing process when building tx payload
50448a2
@thibault-martinez
Add wots support
3a5bfa5
@thibault-martinez
Update changes from bee-signing
9119f50
@thibault-martinez
Add sematic verification for ed25 signature
834edf8
@thibault-martinez
Simplifiy Signature Unlock
5b642a2
@thibault-martinez
Update error type using thiserror
121611c
@thibault-martinez
Box payload enum varients
908e4ba
@thibault-martinez
Derive Clone for all objects
d1bbc27
@thibault-martinez
Fix index type in legacy bundle
1a34cd8
@thibault-martinez
Update index to BIP32Path
5586029
@thibault-martinez
Add prelude module
f1cd601
@thibault-martinez
Update changes from BIP32Path
94644dd
@thibault-martinez
Update changes from slip10 v0.4
1bf21f0
@thibault-martinez
Add Serialize trait to UnsignedTransaction
9888dfa
@lucasfernog @thibault-martinez
fix(deps) use bee dev branch
c00678e
@thibault-martinez thibault-martinez merged commit d91bea6 into Alex6323:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-martinez thibault-martinez thibault-martinez left review comments

@pvdrz pvdrz pvdrz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wusyong @thibault-martinez @pvdrz @lucasfernog