Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter encoding #26

Merged
merged 3 commits into from
Jun 5, 2018
Merged

Fix parameter encoding #26

merged 3 commits into from
Jun 5, 2018

Conversation

AlexGhiondea
Copy link
Owner

The parameter values for the authorization header should be between double quotes.
…en double quotes

The code that extracts the value of the oauth parameter is updated to validate the presence of the double quotes and strip them before returing the value of the header.
With this change, tests don't have to validate the parameter is between double quotes and instead can validate the actual value directly.
Copy link
Collaborator

@SimonTouchtech SimonTouchtech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimonTouchtech SimonTouchtech merged commit 0ef4560 into master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants