Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parameter encoding #26

Merged
merged 3 commits into from
Jun 5, 2018
Merged

Fix parameter encoding #26

merged 3 commits into from
Jun 5, 2018

Commits on Jun 4, 2018

  1. Ensure the parameters are specified according to the spec 

    The parameter values for the authorization header should be between double quotes.
    @AlexGhiondea
    AlexGhiondea committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    fc04f1b View commit details
    Browse the repository at this point in the history

  2. Update the tests to account for the fact that oauth headers are betwe… 

    …en double quotes

The code that extracts the value of the oauth parameter is updated to validate the presence of the double quotes and strip them before returing the value of the header.
With this change, tests don't have to validate the parameter is between double quotes and instead can validate the actual value directly.
    @AlexGhiondea
    AlexGhiondea committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    3e3bec4 View commit details
    Browse the repository at this point in the history

  3. Bump the minor package version in preparation for release.

    @AlexGhiondea
    AlexGhiondea committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    5edbc7a View commit details
    Browse the repository at this point in the history