Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render a simple triangle #4

Closed
3 tasks done
Tracked by #2
AlexandruIca opened this issue Oct 21, 2021 · 0 comments
Closed
3 tasks done
Tracked by #2

Render a simple triangle #4

AlexandruIca opened this issue Oct 21, 2021 · 0 comments
Assignees
@AlexandruIca
Labels
feature New feature or request
Projects
Backlog
Milestone
First Triangle!

Comments

@AlexandruIca
Copy link
Owner

AlexandruIca commented Oct 21, 2021 •
edited

Follow the algorithm presented here and render a simple triangle for the start. Maybe add a post-processing ability to take into account color spaces. Ideally we should also take into account alpha compositing but it's ok if it's not fully correct for now.
@AlexandruIca AlexandruIca added the feature New feature or request label Oct 21, 2021
@AlexandruIca AlexandruIca self-assigned this Oct 21, 2021
@AlexandruIca AlexandruIca mentioned this issue Oct 21, 2021
Closed
2 tasks
@AlexandruIca AlexandruIca added this to ToDo in Backlog via automation Oct 27, 2021
@AlexandruIca AlexandruIca added this to the First Triangle! milestone Oct 27, 2021
AlexandruIca added a commit that referenced this issue Dec 18, 2021
@AlexandruIca
core: Implement round_to_grid for Point (#4)
9320624 
A simple function that fits a point to a grid of `WIDTH * HEIGHT *
NUM_CHANNELS`, with `pixel_size * pixel_size` subpixels
AlexandruIca added a commit that referenced this issue Dec 18, 2021
@AlexandruIca
core: Add background color parameter for CanvasDescription (#4)
937001e
AlexandruIca added a commit that referenced this issue Dec 18, 2021
@AlexandruIca
test: Check if the background color is set accordingly (#4)
9b94c10
AlexandruIca added a commit that referenced this issue Dec 18, 2021
@AlexandruIca
core: Implement buffer_set_at and buffer_get_at (#4)
48ebcca 
For easier access to the buffer's colors.
AlexandruIca added a commit that referenced this issue Dec 18, 2021
@AlexandruIca
test: Check if buffer colors are set accordingly (#4)
ecac8cf
AlexandruIca added a commit that referenced this issue Dec 18, 2021
@AlexandruIca
core: buffer_get_at should take a &self instead of &mut self (#4)
de65be1
AlexandruIca added a commit that referenced this issue Dec 18, 2021
@AlexandruIca
core: Try implement a few geometry algorithms (#4)
90c94b8 
Failed, but will come back after working on other issues first.
AlexandruIca added a commit that referenced this issue Feb 11, 2022
@AlexandruIca
core: First port of the line intersection algorithm from Haskell (#4)
6bd804c
AlexandruIca added a commit that referenced this issue Feb 11, 2022
@AlexandruIca
core: Heavily refactor the line intersection algorithm (#4)
7d47220 
The code is now much more modular/reusable, more to come!
AlexandruIca added a commit that referenced this issue Feb 13, 2022
@AlexandruIca
core: Use the new intersect_line_with_grid method for rendering lines
89b9ccc 
(#4)
AlexandruIca added a commit that referenced this issue Feb 13, 2022
@AlexandruIca
core: Default for Color should be an opaque black (#4)
946de98
AlexandruIca added a commit that referenced this issue Feb 13, 2022
@AlexandruIca
test: Make the background for the test white (#4)
ba4aa3c 
So that it's much easier to see if rendering is done correctly or not.
AlexandruIca added a commit that referenced this issue Mar 10, 2022
@AlexandruIca
test: Add a new line for line_test (#4)
68cb7a7
AlexandruIca added a commit that referenced this issue Mar 10, 2022
@AlexandruIca
test: Add horizontal/vertical lines for testing (#4)
cf710c6
AlexandruIca added a commit that referenced this issue Mar 10, 2022
@AlexandruIca
test: Give the line test a suggestive name (#4)
e2158f7
AlexandruIca added a commit that referenced this issue Mar 10, 2022
@AlexandruIca
core: Avoid useless computations when handling horizontals/verticals
e723179 
(#4)
AlexandruIca added a commit that referenced this issue Mar 10, 2022
@AlexandruIca
core: Implement the first version of the line rasterizer (#4)
5b005bb
AlexandruIca added a commit that referenced this issue Apr 3, 2022
@AlexandruIca
core: Implement clamp method for Color (#4)
0d591a0 
This function clamps each color's RGB channel to the range [0.0, 1.0]
AlexandruIca added a commit that referenced this issue Apr 3, 2022
@AlexandruIca
core: Fix a few bugs and try (unsuccessfully) new things in
e64bc07 
`geometry.rs` (#4)

We'll have to see what we do with this file, currently we don't need
it, but it would be nice to transfer some stuff from `canvas.rs` into
here.
AlexandruIca added a commit that referenced this issue Apr 3, 2022
@AlexandruIca
test: Render the background as a rectangle (#4)
eb9e7db 
Unfortunately we have a bug where we can't specify the limits to be
`WIDTH` and `HEIGHT` because we get an out-of-bounds error.
AlexandruIca added a commit that referenced this issue Apr 3, 2022
@AlexandruIca
test: Add more meaningful tests to line_test.rs (#4)
2b98a5a
AlexandruIca added a commit that referenced this issue Apr 3, 2022
@AlexandruIca
core: Change the line rendering algorithm (#4)
59bd20e 
The old algorithm was a bit too complex to implement correctly. I was
stuck with the coverage computation, I just couldn't find a way to
compute the trapezoidal area correctly and robustly.

Being tired, I decided to follow `font-rs`'s choice of line rendering
algorithm with Levien-style anti-aliasing. It gives excellent results
and (at least at first) seems kind of easy to understand. I'll have to
see how I can implement the even-odd fill rule with this one. Right now
I'm thinking about checking when the coverage changes its sign, but I
don't know if that's the correct way, we'll see.
AlexandruIca added a commit that referenced this issue Apr 3, 2022
@AlexandruIca
test: Add first triangle tests (#4)
8bbd828
AlexandruIca added a commit that referenced this issue Apr 3, 2022
@AlexandruIca
test: Add first rectangle tests (#4)
f045305 
This tests the non-zero fill rule with rects inside rects.
Backlog automation moved this from ToDo to Done Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexandruIca AlexandruIca

Labels
feature New feature or request
Projects
Backlog
Done
Milestone
First Triangle!
Development

No branches or pull requests
1 participant
@AlexandruIca