Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the shape API #9

Closed
Tracked by #4
AlexandruIca opened this issue Dec 17, 2021 · 0 comments · Fixed by #15
Closed
Tracked by #4

Refactor the shape API #9

AlexandruIca opened this issue Dec 17, 2021 · 0 comments · Fixed by #15
Assignees
@AlexandruIca
Labels
refactor Improve the code
Projects
Backlog
Milestone
First Triangle!

Comments

@AlexandruIca
Copy link
Owner

Currently a Shape is a Vec<Primitive>, and it's not ideal. We should make an API that kind of looks like turtle:

Shape {
    start: (0, 0),
    data: vec![
        LineTo{ 120, 350 },
        QuadraticTo { ... },
    ],
}
@AlexandruIca AlexandruIca added the refactor Improve the code label Dec 17, 2021
@AlexandruIca AlexandruIca added this to the First Triangle! milestone Dec 17, 2021
@AlexandruIca AlexandruIca self-assigned this Dec 17, 2021
@AlexandruIca AlexandruIca added this to ToDo in Backlog via automation Dec 17, 2021
@AlexandruIca AlexandruIca mentioned this issue Dec 17, 2021
Closed
3 tasks
AlexandruIca added a commit that referenced this issue Mar 23, 2022
@AlexandruIca
core: Modify the Shape type with usual vector graphics "API" (#9)
a688a06 
That is: instead of having a `Vec` of primitives, we have a `Vec` of
path "operations", like "MoveTo"/"LineTo"/etc., which is the
conventional way of describing a path.
AlexandruIca added a commit that referenced this issue Mar 23, 2022
@AlexandruIca
core: Use the new Shape type (#9)
062b7b0
AlexandruIca added a commit that referenced this issue Mar 23, 2022
@AlexandruIca
test: Update the line test using the new Shape API (#9)
ee8e8be
@AlexandruIca AlexandruIca linked a pull request Mar 23, 2022 that will close this issue
#9 Shape API refactoring #15
Merged
Backlog automation moved this from ToDo to Done Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexandruIca AlexandruIca

Labels
refactor Improve the code
Projects
Backlog
Done
Milestone
First Triangle!
Development

Successfully merging a pull request may close this issue.

#9 Shape API refactoring AlexandruIca/verg
1 participant
@AlexandruIca