App Icons for hyprland/window
#2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented for hyprland
(class for xwayland under sway)
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces App Icons for the
hyprland/windowmodule (as requested in #1925)Since this required almost no changes from the code for
sway/windowand I didn't want to duplicate the code, I introduces a newAAppIconLabelclass which now bothhyprland/windowandsway/windowinherit from. The sway implementation usesapp_classifapp_idis not set (appears to be the case if the window is running under xwayland) but I wasn't really able to find a suitable replacement for that with hyprland (app_idseems to correspond to hyprlandsclassthough).Tested on both hyprland and sway