Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyprland/workspaces: use named icons instead of searching by id #2393

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

zjeffer
Copy link
Contributor

@zjeffer zjeffer commented Aug 10, 2023

Bug report by @VincentBerthier:

It seems the icons for the workspaces specified in the configuration only work if they’re specified for a workspace ID, not its name.

This PR should fix this. @VincentBerthier can you test this?

@VincentBerthier
Copy link

Erm, I changed my config to use IDs now which wouldn’t be too much of a problem, but I’m also playing around with NixOS and I don’t think I have anything installed to test this sorry :o

@zjeffer
Copy link
Contributor Author

zjeffer commented Aug 12, 2023

Alright, it seems to work on my system and it makes more sense to use name instead of id, so this can be merged @Alexays

@Alexays Alexays merged commit 2c7bbe9 into Alexays:master Aug 14, 2023
8 checks passed
@zjeffer zjeffer deleted the hyprland/fixes branch August 14, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants