Implement 'active_only' option and 'visible' class in hyprland/workspaces

[zjeffer]

With this PR, active_only can be set to true, which will only show the active workspace.

If I understand the feature request correctly, each monitor should show the currently visible workspace, right? This PR currently only shows the active one as reported by Hyprland, so if a monitor is not focused, it will not show any workspaces. Is this supposed to happen? I would expect it to be better if each monitor shows one "active" workspace, i.e. the one currently visible.

Let me know if this can be improved.

CC @Anakael @MightyPlaza

[zjeffer]

Once urgent workspaces are implemented in this module, we can simply add a check for this->urgent() here. Then it would work the same as in the wlr/workspaces module.

[MightyPlaza]

i think it should show the current visible workspace in the bar's monitor or the active globally in case of all-outputs option is used

persistent workspaces probably shouldn't be affected by this option since they can be set by the user in the config

(if possible test format-icons with persistent and active workspaces, I haven't tested it yet, but some guys were saying it wasn't working)

[MightyPlaza]

the rest LGTM

[zjeffer]

(if possible test format-icons with persistent and active workspaces, I haven't tested it yet, but some guys were saying it wasn't working)

What would be the preferred behaviour? If a persistent workspace is active, should it show the active icon (current behaviour) or the persistent icon? The current behaviour seems to work fine for me.

[MightyPlaza]

"hyprland/workspaces": {
    "persistent_workspaces": {
        //"1":[],"2":[],"3":[],"4":[],"5":[],"6":[],"7":[],"8":[],"9":[]
        "*": 10
    },
    "disable-scroll": false,
    "all-outputs": false,
    "warp-on-scroll": false,
    "on-click": "activate",
    "format": "{icon}",
    "format-icons": {
        "1":"一","2":"二","3":"三","4":"四","5":"五","6":"六","7":"七","8":"八","9":"九","10":"十"
    }
},

this config for example

was not working as intended, not sure if it has been fixed

[zjeffer]

Ah, I thought you meant something like this, which does work:

    "format-icons": {
      "default": "O",
      "active": "a",
      "persistent": "p",
      "special": "s"
    },

Your example indeed doesn't work, I'll fix that.

EDIT: Nevermind, it does work on the current master (I was looking at the wrong monitor). I think it may have been fixed here: #2393

[zjeffer]

Sorry this took so long, I haven't had much time lately and I kept getting issues compiling due to the fmt & spdlog stuff. Should be ready to review now.

Let me know if this is the correct behaviour or not:

• Setting both active-only and all-outputs to true => each bar will show all monitor's visible workspaces, and mark the globally active one as active, and the rest as visible.
• Setting active-only to true and all-outputs to false => each bar shows only its visible workspace. The focused monitor shows the visible workspace as active.
• Setting active-only to false and all-outputs to true => each bar shows all non-empty workspaces (so each bar shows the exact same thing)
• Setting both to false => Each bar shows that monitor's non-empty workspaces (default behaviour).
• Persistent workspaces are not effected, those are always shown.

[zjeffer]

The visible css class doesn't seem to be working yet for me, but the visible icon does work, investigating...

EDIT: nevermind, I mistyped the css classname in my style.css file (workspace instead of workspaces). Works properly.

[MightyPlaza]

lgtm

[khaneliman]

@zjeffer looks like this needs a rebase btw

[zjeffer]

@Alexays Ready to merge.

[khaneliman]

Closes #2465

[Alexays]

Thanks!

[NotAShelf]

Is it intended behaviour that active-only displays both workspaces if two monitors are at the same time?

[zjeffer]

@NotAShelf only if all-outputs is true. If it's false, it should only show the current monitor's active workspace.

[NotAShelf]

Understood. Any chance we could get a rule to see one active workspace at a time, regardless of monitor? Similar to active-only + all-outputs behaviour on wlr/workspaces

[zjeffer]

Do you mean you want to see the same active workspace on every monitor? Like if workspace 1 is active on monitor 1, you also want to see "1" in monitor 2?

[NotAShelf]

More or less, yes. I have a single bar on monitor 1, and I'd love to see only the active workspace. For example if workspace 1 is on monitor 1 and workspace 5 is on monitor 2, it would display only the focused workspace, which is either 1 or 5 depending on which monitor I'm on.

[Diaoul]

I'm looking for a way to have active workspace (e.g. 9) on a not focused monitor (e.g. B) to have a different style applied to it on the bar on monitor B compared to other workspaces there.

Reading this, I'm not sure it is possible nor which combination to try 😕

Edit: Running git version seems to have improved things!