Fix: Hyprland's special workspaces aren't cleared #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes Alexays#2505 Co-authored-by: Gabriel Fox <Inbox@GabrielFox.Dev>
see hyprwm/Hyprland#3424 for more info Co-authored-by: Gabriel Fox <Inbox@GabrielFox.Dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2505
About this PR
This PR makes sure special workspaces can be removed. Before this, the code for
Workspaces::remove_workspace()didn't account for the workspaces starting withspecial:in their names, which resulted in the workspace not being found and, thus, not being removed.Additional changes
During the investigation of this bug, I also stumbled upon Hyprland creating special workspaces twice. The second workspace always seems to be called
special:+ the name of the first special workspace, resulting in "doubled specials" (special:special:<some_name>). This PR also prevents the creation (and deletion) of workspaces namedspecial:special:, which served no purpose and would linger a few seconds in the user's bar. See hyprwm/Hyprland#3424 for more info.Related PR