hyprland/workspaces improvements

[MightyPlaza]

Some improvements to the hyprland/workspaces modules

adds workspace clicking support (except for the non named special workspace which seems to be an issue on hyprland's side)

adds "all-ouptuts" and "show-special" to config

listens to "focusedmon" and "moveworkspace" events

actually implements "{name}" format which was present on the wiki but wasn't implemented (opposite of "{id}")

fixes issues with previous event implementation on named workspaces

adds more variables to the workspaces

sorts workspaces in the order normal -> named -> special -> named special, instead of id

didn't find any other issues/bugs

will also ping @Anakael @zjeffer in case I accidentally broke something

[zjeffer]

Great, thanks for this! I'll do some tests with this tomorrow with multiple monitors.

I just compiled and ran it on a single monitor, and I had a segfault after switching to the fourth workspace, when it creates the new workspace button. I can't seem recreate it again, so I'll do some more testing.

[Anakael]

Can you please explain what named, special and named special workspaces are?

[Anakael]

Can you please explain what named, special and named special workspaces are?

I've found it in wiki.

[MightyPlaza]

there seems to be an issue with dispatcher that makes giving no args use the dispatcher as arg, that's why clicking the non named special workspace doesn't work.
currently trying to fix it and other issues on hyprland's side

[zjeffer]

This might not be a big problem but I notice the workspace creation is much slower than the wlr/workspaces implementation. Here's a video showing my bar with wlr/workspaces at the top, and your implementation on the bottom:

2023-07-16.10-24-52.mp4

I quickly scroll through the workspaces, and have to wait every once in a while to let the bottom bar update.

I built the latest master and noticed it doesn't have this problem, although it has another problem where it sometimes doesn't destroy the workspaces, resulting in something like this:

---

EDIT: It's probably due to calling hyprctl workspaces to get the workspace json data, so I guess not something that can be improved much. Nevermind.

[MightyPlaza]

tested spamming the mouse wheel and it seems to update at the same speed as wlr. Also seems to be updating at the same speed as the IPC socket.
The duplicated issue, tried to spam the mouse wheel and hyprctl but can't repro.
Probably caused by existing a remove and a create workspaces shared vector.
To fix it, something else needs to be used, maybe a combined list of the workspaces that need updating, what do you guys think?

[MightyPlaza]

fixed one of the issues for clicking the main special workspace on hyprland's side.
should be in the main branch soon
Edit: also had to change previous waybar code for the intended implementation
clicking on all workspaces should be fully working now

[MightyPlaza]

I suggest this gets merged now, since the only issue is the non removed workspaces which only happen on spamming the mouse wheel.
That should be fixed, in my opinion, by using a vector of combined DTO to create/destroy, which will likely be a major rewrite, so will take some time.
What do you guys think?

[zjeffer]

since the only issue is the non removed workspaces which only happen on spamming the mouse wheel.

To clarify: this problem only occured for me on the master branch, not on this PR's branch. On this PR's branch, it's just a little slower compared to wlr/workspaces when creating & destroying hundreds of workspaces per second. Not a big deal.

I agree it can be merged now.

[zjeffer]

@Alexays can this be merged? I added persistent workspaces on my own fork and would like to open a separate PR for this.

[Alexays]

Yes, LGTM

[sudg6]

on-click: activate is not working, nor can I click to switch to any workspace button!

[Edit]
pacman manager is still hosting an outdated version of Waybar.
I compiled it under my Arch Linux machine and had an issue with loading the libcanva.so library but manually fixed it as discussed here.

[zjeffer]

on-click: activate is not working, nor can click to switch to any workspace button!

This has been fixed in #5013, @Alexays just needs to make a new release, or you can compile it yourself.

[zjeffer]

@sudg6 your edit is incorrect

pacman manager is still hosting an outdated version of Waybar.

this is not Arch's or pacman's fault. There simply isn't a release yet that includes the fix.