Using 'image-missing' fallback if no taskbar icon is found #2677
Conversation
| @@ -304,6 +315,10 @@ Task::Task(const waybar::Bar &bar, const Json::Value &config, Taskbar *tbar, | |||
| with_icon_ = true; | |||
| } | |||
|
|
|||
| if (app_id_.empty()) { | |||
| handle_app_id("unknown"); | |||
There was a problem hiding this comment.
The function handle_app_id(), which sets icons, will now be called twice; first here with the parameter app_id = "unknown", and then again once Wayland provides the actual app_id. In this first explicit call, the "image-missing" fallback is being set. In the second call invoked by Wayland, the icon is overwritten by the actual app image. If the program does not set an app_id correctly, this second call will not take place, and the "image-missing" fallback is being kept.
| pixbuf = DefaultGtkIconThemeWrapper::load_icon("image-missing", scaled_icon_size, | ||
| Gtk::IconLookupFlags::ICON_LOOKUP_FORCE_SIZE); |
There was a problem hiding this comment.
The "image-missing" icon is maybe not the prettiest, something like this maybe looks prettier. A different approach is thus to bundle in a fallback icon in resources/icons (and update resources/icons/waybar_icons.gresource.xml).
This line is then replaced by pixbuf = Gdk::Pixbuf::create_from_resource("/fr/arouillard/waybar/icons/scalable/apps/default-app-icon", scaled_icon_size, scaled_icon_size)
If bundling an icon preferred, I am happy to use this approach instead and change the PR accordingly.
|
LGTM, thx! |
Icons are sometimes not found in the taskbar, for two reasons:
app_id, so lookup is impossible.If the user has configured Waybar to only show applications as icons, this means that the program is now essentially "hiding":
With this patch, when an icon cannot be found, Waybar will now load the "image-missing" icon of Gtk: