Specify config is JSONC #2744
Merged
Specify config is JSONC #2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON is JSONC
Since the file can also be named config.jsonc, that will remove ambiguity
|
Thanks! |
alebastr
added a commit
to alebastr/Waybar
that referenced
this pull request
Feb 25, 2024
Only changes the name of the default config we install and does not affect the lookup logic in any way. Man pages were already fixed in Alexays#2744
alebastr
added a commit
to alebastr/Waybar
that referenced
this pull request
Feb 25, 2024
Only changes the name of the default config we install and does not affect the lookup logic in any way. Man pages were already fixed in Alexays#2744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always find pure JSON cumbersome for configuration files due to the lack of support for comments. Seeing up-front that the configuration file is actually JSONC would have aided my adoption of waybar.
Changes proposed in this pull request: